FreeBSD Port

Hello there,

nxlog currently does not compile out of the Box on FreeBSD.

• It assumes that pthread_t can be cast to an unsigned long (on FreeBSD it' an opaque typedef to struct pthread *)
• It uses SSLv3_method which is gone from newer versions of OpenSSL.

This can be fixed by applying the patch at the end of this posting.

I'd like to submit a FreeBSD port for nxlog, but I do need more information on what you consider okay and not okay wrt. to distribution.

As far as §4 (ii) of the license goes, the patch would need to include "you must include a prominent notice that you
have modified the file, including your name, your e-mail address (if any), and the date and purpose of the change;".

I would consider this making the patch more brittle, so I'd like to avoid it.

It would be better to actually have these changes upstream.

The use of pthread_getthreadid_np() is non-portable, which I'd like to replace with proper calls to CRYPTO_THREADID_set_callback() after some more testing.

Kind regards,

  Peter

--- src/common/ssl.c.orig    2014-07-19 15:52:06.000000000 +0200
+++ src/common/ssl.c    2017-07-12 20:10:38.983907000 +0200
@@ -10,6 +10,9 @@
 #include "../core/nxlog.h"
 #include "error_debug.h"
 #include "ssl.h"
+#ifdef __FreeBSD__
+#include <pthread_np.h>
+#endif /* !__FreeBSD__ */
 
 #define NX_LOGMODULE NX_LOGMODULE_MODULE
 
@@ -43,7 +46,13 @@
 {
     unsigned long ret;
     
+#ifdef __FreeBSD__
+    pthread_t    thr;
+    thr = apr_os_thread_current();
+    ret = (unsigned long)pthread_getthreadid_np();
+#else
     ret = (unsigned long) apr_os_thread_current();
+#endif /* !__FreeBSD__ */
 
     return ( ret );
 }
@@ -369,7 +378,7 @@
     throw_msg("error allocating BIO from socket");
     }
 
-    meth = SSLv3_method();
+    meth = TLS_method();
     if ( meth == NULL )
     {
     nx_ssl_error(FALSE, "failed to init SSLv23");